[manila-csi-plugin] Restore --nodeid and --nodeaz as optional overrides#3140
Open
gouthampacha wants to merge 1 commit into
Open
[manila-csi-plugin] Restore --nodeid and --nodeaz as optional overrides#3140gouthampacha wants to merge 1 commit into
gouthampacha wants to merge 1 commit into
Conversation
kubernetes-prow
Bot
added
release-note
kubernetes-prow
Bot
added
the
size/L
Contributor
Author
|
@kayrus @yahor-kurachkin could you review this when you get a chance? |
kayrus
reviewed
Jul 17, 2026
| ShareName string `name:"shareName" value:"optionalIf:shareID=." precludes:"shareID"` | ||
| ShareAccessID string `name:"shareAccessID" value:"optionalIf:shareAccessIDs=." precludes:"shareAccessIDs"` // Keep this for backwards compatibility | ||
| ShareAccessIDs string `name:"shareAccessIDs" value:"optionalIf:shareAccessID=." precludes:"shareAccessID"` | ||
| ShareAccessID string `name:"shareAccessID" value:"optional"` // Deprecated: use shareAccessIDs |
Contributor
There was a problem hiding this comment.
could you please make this change in a separate PR?
Contributor
Author
There was a problem hiding this comment.
ugh, this is my bad, it was a part of a different PR: #3132
kayrus
reviewed
Jul 17, 2026
| } | ||
|
|
||
| err = d.SetupNodeService(metadata) | ||
| err = d.SetupNodeService(nodeID, nodeAZ, md) |
Contributor
There was a problem hiding this comment.
this change needs to be aligned with #3141
@gouthampacha can you check the #3141 as well?
Contributor
Author
yahor-kurachkin
left a comment
yahor-kurachkin
left a comment
Contributor
There was a problem hiding this comment.
Just a minor comment about the testing approach. Otherwise LGTM.
gouthampacha
force-pushed
the
worktree-restore-nodeid-flags
branch
from
July 25, 2026 06:27
653de24 to
29c5534
Compare
Un-deprecate the --nodeid and --nodeaz flags so that they can be used as alternatives to the metadata service for node identity. When set, the flag values are used directly; when unset, the driver falls back to the metadata service as before. This allows Manila CSI to work on nodes that are not OpenStack VMs, such as bare metal clusters or edge deployments, where the metadata service is unavailable.
gouthampacha
force-pushed
the
worktree-restore-nodeid-flags
branch
from
July 25, 2026 06:37
29c5534 to
7dfe7bf
Compare
Contributor
|
/test pull-cloud-provider-openstack-check |
Contributor
|
/lgtm |
kubernetes-prow
Bot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kayrus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Un-deprecates the
--nodeidand--nodeazflags so they can be used asalternatives to the metadata service for node identity.
#2734 aligned Manila CSI with how Cinder CSI handles node identity by making
the metadata service mandatory. For Cinder this makes sense: the node must be
a Nova VM for volume attach/detach. Manila doesn't have that constraint. Shares
mount via NFS or CEPHFS on the host, and the node doesn't need to be a Nova
instance.
When
--nodeidis set, the flag value is used directly. When unset, the driverfalls back to the metadata service (current behavior). Same for
--nodeaz.OpenStack deployments are unaffected.
Which issue this PR fixes(if applicable):
Fixes #3139
Special notes for reviewers:
Tested end-to-end on a DevStack environment with Manila LVM:
--nodeid=test-node-from-flag: CSINode registers with the flag value,PVC binds, share mounts, pod reads/writes data
--nodeid(default): CSINode registers with the metadata-providedUUID, PVC binds, share mounts, pod reads/writes data
Release note: